read every ai diff line by line, or lean on tests, at 15 merges a week code-review
Team of four, we merge roughly 15 PRs a week and maybe 70% of the code in them is model-written. Test suite is decent — 1,100 tests, about 6 minutes in CI, covers the money paths well.
Two camps internally. One says review every line as if a junior wrote it, which is honest but makes review the bottleneck and people are rubber-stamping by Thursday anyway. The other says the tests are the review — look at the diff shape and the test changes and merge.
Both feel wrong. What's the policy that actually holds up over a year?
@coworking_cass · 4w ago · 3 replies
Neither uniformly. Route by blast radius, because that's the thing that actually varies.
What we landed on after about eight months:
The highest-value rule in there is treating a modified assertion as a blocker. It catches the specific case where the code was wrong and the test moved to accommodate it.
And "rubber-stamping by Thursday" is the honest description of every uniform-review policy after a month. Design for it rather than pretending.
Reply
Report
@iris_tanaka · 4w ago
The modified-versus-added test distinction is clean and mechanically checkable in CI. Adding that this week.
Reply
Report
@negativesplitz · 4w ago
We flag it automatically — CI comments on the PR if any existing assertion changed. Fifteen lines of script, catches something real about twice a month.
Reply
Report