Ask
149
@schema_drift_lu ·

Our output tripled and now the review queue is the bottleneck — how did your team change process?

Five developers, everyone using agents, and our PR count went from about 12 a week to just over 40. Nothing else changed, so review is now the constraint and two of the five are visibly burning out on 900 line diffs that were generated in twenty minutes and take two hours to read properly. Merging faster with less review is not something I want to propose. What did your team actually change, and did it hold after a month?

9 answers Share
Report

Answering anonymously — a moderator will review it first.

  • @egress_egon · 2mo ago

    We added a second required reviewer, reasoning that more eyes would catch more. Throughput halved, both reviewers assumed the other was reading carefully, and the two worst bugs of the quarter went through with two approvals each. We reverted it after five weeks. Diffusion of responsibility is real and adding people to a review is the wrong lever.

    73
    Share
    Reply

    Answering anonymously — a moderator will review it first.

    Report
  • @rollback_rae · 2mo ago · 3 replies

    Caps produced pure theatre for us: seven PRs that had to be merged in order, each individually reviewable and collectively incomprehensible, which is worse than one honest large one. What actually worked was requiring the author to write the PR description by hand, with no generation, covering what changed, what they considered and rejected, and what they are least sure about. It takes ten minutes and it is a filter, because anyone who cannot write it has not read their own diff and the PR goes back before a reviewer touches it.

    104
    Share
    Reply

    Answering anonymously — a moderator will review it first.

    Report
    • @coopvent_cal · 2mo ago

      We do both and I would agree the description rule catches a different failure. The stacked PR problem is real though, we only avoided it because the cap is soft and the override is easy.

      48
      Share
      Reply

      Answering anonymously — a moderator will review it first.

      Report
    • @schema_drift_lu · 2mo ago

      The what I am least sure about line is something I want regardless of anything else we change.

      29
      Share
      Reply

      Answering anonymously — a moderator will review it first.

      Report
  • @yaml_yusuf · 2mo ago · 3 replies

    Hard cap of 400 changed lines per PR, enforced by a bot that refuses to assign a reviewer above it, with an explicit override that requires a sentence explaining why. Our median PR went from 610 lines to 180 within three weeks, review turnaround went from about 19 hours to under 4, and total merged volume stayed roughly the same. The interesting part was that the cap changed how people prompted rather than how they split PRs, because they stopped asking for whole features in one go. It has held for eight months.

    132
    Share
    Reply

    Answering anonymously — a moderator will review it first.

    Report
    • @schema_drift_lu · 2mo ago

      Changed how people prompted rather than how they split is the bit I would not have predicted and is probably the actual mechanism.

      37
      Share
      Reply

      Answering anonymously — a moderator will review it first.

      Report
    • @dbt_and_dust · 2mo ago

      We did the same and the override sentence is doing more work than the cap. Nobody wants to write I did not want to split this.

      44
      Share
      Reply

      Answering anonymously — a moderator will review it first.

      Report
  • @dbt_and_dust · 2mo ago

    We measured review time per hundred lines before we changed anything, which I would recommend before you pick a fix. Ours came out at roughly 11 minutes per hundred lines for hand written code and 17 for generated code, because reviewers were checking for plausible looking nonsense as well as correctness. That number is the argument you take to your lead: it is not that there is more code, it is that each line costs more to review than it used to.

    81
    Share
    Reply

    Answering anonymously — a moderator will review it first.

    Report
  • @goroutine_gil · 3h ago

    Cap the diff, make the author write the description, and make the person who generated it the person who is paged when it breaks. The third one fixes more than the first two.

    1
    Share
    Reply

    Answering anonymously — a moderator will review it first.

    Report